More updates!!!!

components/susignup.php

@@ -9,19 +9,20 @@ include "../suapi.inc.php";
 
 $mode = 'login';
 //login
-if(isset($_REQUEST['sid'])&&isset($_REQUEST['transactionID'])&&$_REQUEST['sid']!=''&&$_REQUEST['transactionID']!=''){
+if(!empty($_REQUEST['sid'])&&!empty($_REQUEST['transactionID'])){
 //set signup details
 	
 	$sid = $_REQUEST['sid'];
         $transactionID = $_REQUEST['transactionID'];
                                             
 	//set POST variables
-	$url = "https://'$suapi_user':'$suapi_pass'@hap.swansea-union.co.uk/memberships/Membership.asmx/GetMemberByTransactionID";
+	$url = "https://$suapi_user:$suapi_pass@hap.swansea-union.co.uk/memberships/Membership.asmx/GetMemberByTransactionID";
 	$fields = array(
 	       'transactionID'=>urlencode($transactionID),
 	       'GroupingID'=>urlencode($GroupingID),
 	       );
 	//url-ify the data for the POST
+	$field_string = "";
 	foreach($fields as $key=>$value) { $fields_string .= $key.'='.$value.'&'; }
 	rtrim($fields_string,'&');
 	//open connection
@@ -37,7 +38,7 @@ if(isset($_REQUEST['sid'])&&isset($_REQUEST['transactionID'])&&$_REQUEST['sid']!
 
 	//close connection
 	curl_close($ch);
-	if(!result){
+	if(!$result){
 	//HTTP Error
 	}else{	
   		$re1='.*?';	
@@ -71,43 +72,47 @@ if(isset($_REQUEST['sid'])&&isset($_REQUEST['transactionID'])&&$_REQUEST['sid']!
 			$attribs[]=$array['cardNumber'];
 			$attribs[]=$array['personID'];
 
-
+			$valid = true;
 			if(!$sucsDB->Execute($query,$attribs)) {
-				unset($query);
-				unset($attribs);
 				$query = "SELECT * FROM transactions WHERE transactionID = ? AND signupid IS NULL";
+				$attribs= array();
 				$attribs[]=$transactionID;
 				$data = $sucsDB->GetAll($query,$attribs); 
 				if(is_array($data)&&sizeof($data)==1){
+					
+					
 					//ERROR SOMEONE TRIED TO USE SAME TRANSACTIONID TWICE SIGNUP SLIP ALREADY GENERATED
 					// MAIL ERROR MESSAGE THEN DIE
-					die();
+					$valid = false;
 				}
 			}
-				
-			$pass = make_password();		
-			unset($query);
-			$query = "insert into signup (password,sid,issuedby) values( ?, ?, ?) returning id";
-			unset($attribs);
-			$attribs[]=addslashes($pass);
-			$attribs[]=$array['cardNumber'];
-			$attribs[]='SUSU API';
+
+			if($valid)
+			{
+				$pass = make_password();		
+				unset($query);
+				$query = "insert into signup (password,sid,issuedby) values( ?, ?, ?) returning id";
+				unset($attribs);
+				$attribs[]=addslashes($pass);
+				$attribs[]=$array['cardNumber'];
+				$attribs[]='SUSU API';
 			
-			$id = $sucsDB->Execute($query,$attribs);
-                    	if (!$id) {
-                              	echo "Entering id $id failed.<br>\n";
-                        } else {
+				$id = $sucsDB->Execute($query,$attribs);
+	                    	if (!$id) {
+        	                      	echo "Entering id $id failed.<br>\n";
+                	        } else {
                                  	
-				unset($query);					
-				$query = "update transactions set signupid = ? WHERE transactionID = ?";
-				unset($attribs);
-				$attribs[]=$id;
-				$attribs[]=$transactionID;
-				if(!$sucsDB->Execute($query,$attibs)) {
-					//ERROR
-				} else {
-	        	              	$smarty->assign("id", $id);
-              			        $smarty->assign("pass", $pass);
+					unset($query);					
+					$query = "update transactions set signupid = ? WHERE transactionID = ?";
+					unset($attribs);
+					$attribs[]=$id;
+					$attribs[]=$transactionID;
+					if(!$sucsDB->Execute($query,$attibs)) {
+						//ERROR
+					} else {
+		        	              	$smarty->assign("id", $id);
+              				        $smarty->assign("pass", $pass);
+					}
 				}
 			}
 

templates/susignup.tpl

@@ -4,7 +4,7 @@
         <div class="boxhead"><h2>Membership Signup</h2></div>
         <div class="boxcontent">
 
-           <p>Please enter the details from your transaction receipt</p>
+           <p>Please enter transaction ID fromt eh email you received from the union after purchasing membership.</p>
 
             <div class="row">
                 <label for="sid">Student Number:</label>