That coccinelle script works better without the semicolons (duh):

@rule0@
expression A,B;
@@
- lseek(A, B, 0)
+ lseek(A, B, SEEK_SET)
@rule1@
expression A,B;
@@
- lseek(A, B, 1)
+ lseek(A, B, SEEK_CUR)
@rule2@
expression A,B;
@@
- lseek(A, B, 2)
+ lseek(A, B, SEEK_END)

Change scripted with coccinelle:

@rule0@
expression A,B;
@@
- lseek(A, B, 0);
+ lseek(A, B, SEEK_SET);
@rule1@
expression A,B;
@@
- lseek(A, B, 1);
+ lseek(A, B, SEEK_CUR);
@rule2@
expression A,B;
@@
- lseek(A, B, 2);
+ lseek(A, B, SEEK_END);

Also get rid of some unnecessary global variables.

sed does it better.

Half of it relates to MUD mode, the other half is out of date.

Spotted by scan-build

Also make the alias type not-a-pointer to improve readability and
allocate all of the memory required for an alias in one go.

Makes sure we don't create the directories with root ownership.

Also make mwserv's stdout line buffered to work better with logging
systems which capture stdout.

- Run as mw:mw
- Make systemd create and cleanup /var/run/mw for us
- Correct the path to mwserv

(And less shouty.)

Make it static but add a convenience pointer to it to take the place of
the previous user pointer. Make the pointer itself const so that the
compiler complains if anything besides the original user's address is
assigned to it.

And tidy up command.c a bit

Don't start at the beginning of the user db each time.

Huzzah!

!folder name was not working because strlen("name") was expected to be
5. Expect it to be 4 instead.

This moves the folder index, text, moderation and tmp files into
directories corresponding to the file name suffixes currently in use.

Old                     New
---                     ---
STATEDIR/foo.i          STATEDIR/index/foo
STATEDIR/foo.i.m        STATEDIR/index/mod/foo
STATEDIR/foo.i.t        STATEDIR/index/new/foo
STATEDIR/foo.t          STATEDIR/text/foo
STATEDIR/foo.t.m        STATEDIR/text/mod/foo
STATEDIR/foo.t.t        STATEDIR/text/new/foo

This has the following advantages:
1. No more ugly folder path building all over the place
2. STATEDIR and PATHSIZE used in far fewer places
3. No longer assumes paths to folder files will fit in 256 chars
4. A tidier STATEDIR
5. Better separation of concerns (more folder stuff hidden in folders.c)
6. Should make it easier to move the folder stuff into the server
7. Improved error checking/reporting

This makes use of the *at family of syscalls so, instead of building
paths, we now use file descriptors.

An earlier patch accidentally left a zero userposn in ipc_connect but we
don't have a userposn now so ipc_connect now accepts a struct user to
identify as. This makes reconnecting in ipc_check() a little trickier so
pass the stored target in from outside instead of checking for NULL.
Also add some error checking.

Also switch to pread.

We're using user->posn now.

Wrap the userposn and struct person in a new user structure which can be
used to pass around all of the date related to the user, not just the
on-disk bits. This should make things easier down the line when
replacing the users.bb format with a more flexible one.