sucs-site issueshttps://projects.sucs.org/sucssite/sucs-site/-/issues2019-10-02T16:25:21Zhttps://projects.sucs.org/sucssite/sucs-site/-/issues/34Update components/membershiprenew.php to use the new renew_membership() function2019-10-02T16:25:21ZImran Hussainimranh@sucs.orgUpdate components/membershiprenew.php to use the new renew_membership() functioncomponents/membershiprenew.php needs to use renew_membership() in lib/member_functions.phpcomponents/membershiprenew.php needs to use renew_membership() in lib/member_functions.phphttps://projects.sucs.org/sucssite/sucs-site/-/issues/27CSRF Vulnerabilities in forms on SUCS site and arbitrary script/html injection2017-10-10T17:22:08ZChris PiperCSRF Vulnerabilities in forms on SUCS site and arbitrary script/html injectionSUMMARY:
Post requests can be submitted automatically in javascript for some forms from any site and are automatically authenticated if the user was logged in at any point in the browser session and has not logged out (or been timed o...SUMMARY:
Post requests can be submitted automatically in javascript for some forms from any site and are automatically authenticated if the user was logged in at any point in the browser session and has not logged out (or been timed out).
Banana awards allow arbitrary html (including script tags onto the page).
PROOF OF WORK:
Tests were done on https://sucs.org/~elbows/sucssite/ . Users with banana privileges who had previously logged on to elbows sucs site (or had it open in another tab), who visited the url http://ninekaku.com/test [update: now offline, see comments] found a nearly empty page. In the background they had automatically awarded a user called "test" -3 bananas and given as the reason javascript url redirection back to the page http://ninekaku.com/test
SUGGESTED FIX:
Randomly generate a token when the page is loaded and make that part of the post request. If the wrong random string is submitted validation fails.
More details on prevention measures for this type of attack. https://www.owasp.org/index.php/Cross-Site_Request_Forgery_%28CSRF%29_Prevention_Cheat_SheetFix #27https://projects.sucs.org/sucssite/sucs-site/-/issues/11Web Milliways needs to be added as a git submodule2017-10-10T17:22:08ZImran Hussainimranh@sucs.orgWeb Milliways needs to be added as a git submoduleTitle says it all.
https://projects.sucs.org/svn/mw/trunk/webclient/ needs to be added to htdocs/mwTitle says it all.
https://projects.sucs.org/svn/mw/trunk/webclient/ needs to be added to htdocs/mwhttps://projects.sucs.org/sucssite/sucs-site/-/issues/6Fix the URL system2017-10-10T17:22:08ZImran Hussainimranh@sucs.orgFix the URL systemThe URL system is very buggy.
Creating a new post with the following title can screw up the site.
> "test"
or
> it's
We need to either make sure input validation is done everywhere (create a helper function) or change how...The URL system is very buggy.
Creating a new post with the following title can screw up the site.
> "test"
or
> it's
We need to either make sure input validation is done everywhere (create a helper function) or change how we handle URLs so no helper function/input validation is needed.
See:
https://projects.sucs.org/projects/sucs-site/ticket/62
https://projects.sucs.org/projects/sucs-site/ticket/36
I should say without breaking existing URLs, but If an elegant solution comes up then I suppose we can vote on it.