From 7ab02831465a57d4816198bab91fdd9d6bf1f1a5 Mon Sep 17 00:00:00 2001
From: Imran Hussain <imranh@sucs.org>
Date: Mon, 19 Nov 2018 08:48:11 +0000
Subject: [PATCH] Fix banana award system
---
lib/banana-admin.php | 10 +++++-----
templates/banana-award.tpl | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/banana-admin.php b/lib/banana-admin.php
index 8df49d4..e608987 100644
--- a/lib/banana-admin.php
+++ b/lib/banana-admin.php
@@ -23,10 +23,10 @@ if (isset($session->groups[$permission])) {
$smarty->assign("banana_admin", TRUE);
if ($_REQUEST['action'] == "award") {
- if (trim($_POST['why']) !== "") {
- $number = intval($_POST['number']);
+ if (trim($_REQUEST['why']) !== "") {
+ $number = intval($_REQUEST['number']);
- $why = $_POST['why'];
+ $why = $_REQUEST['why'];
if ((abs($number) <= $maxbanana) && $number) {
@@ -46,8 +46,8 @@ if (isset($session->groups[$permission])) {
}
} elseif ($session->loggedin) {
if ($_REQUEST['action'] == "award") {
- $number = intval($_POST['number']);
- $why = $_POST['why'];
+ $number = intval($_REQUEST['number']);
+ $why = $_REQUEST['why'];
// Send a mail to someone about them bananas
$msgbody = $session->username . " thinks $who deserves $number bananas:\r\n";
diff --git a/templates/banana-award.tpl b/templates/banana-award.tpl
index e6f6820..a077c77 100644
--- a/templates/banana-award.tpl
+++ b/templates/banana-award.tpl
@@ -17,7 +17,7 @@
<p><q>Please tell us if you think this user has done something good recently (deserving yellowy recognition)
or something dumb (deserving of greenish derision)</q></p>
{/if}
- <form action="{$url}" method="post">
+ <form action="{$url}" method="post" id="bananaform">
<div>
<input type="hidden" name="action" value="award"/>
@@ -33,7 +33,7 @@
</div>
<div>
<p>Why</p>
- <span class="textinput"><textarea id="bananareason" name="why" cols="25" rows="10"></textarea></span>
+ <span class="textinput"><textarea id="bananareason" name="why" formid="bananaform" cols="25" rows="10"></textarea></span>
</div>
<div>
<span class="textinput"><input type="submit" value="{$action_text}"/></span>
--
GitLab