protection levels aren't working correctly

Protect seems to only let someone be attacked if their ProtectionPower is 0.

As it was there were 2 parts to protection that are oddly munged together (yay)

The old p chatmode flag which is temporary protection and can be turned on/off by anyone with the P chatpriv and the 'new' X/Y style protection which has somewhat odd rules.

the newer X/Y system should be CurrentProtectionLevel/ProtectionPower.

In theory ProtectionPower (not sure that's its exact name) determines the maximum level you can set your (or anyone else's) protection to. It also determines who you can attack based on their currentProtectionLevel. If your ProtectionPower is >= their CurrentProtetionLevel then you can attack them, if not you are blocked from doing so.

examples:

x/4 attacks 4/x - success.

x/3 2 1 or 0 attacks 4/x - failure.

x/2 1 or 0 attacks 3/x - failure. but x/3 or x/4 would succeed.

x/anything attacks 0/x - success (0/x is completely unprotected)

oddly if the p flag is on then it deflects anything but can easily be turned off with a .unpro if the other protection level if low enough for you to use it against them.

It's all a little odd and we might do better just thinking up a new system anyway.

It was generally designed to allow tiers of attack levels but generally everyone has ended up on 4 (protected from newbs but not other people with 4 or 0 vulnerable to everyone)