Changeset 123

Timestamp:

12/09/06 09:56:37 (7 years ago)

Author:

dez

Message:

Fixes Invalid IP issue for proxy-hopping (NTL) users

Files:

• lib/session.php (modified) (2 diffs)
• static/Community.txt (modified) (1 diff)

lib/session.php

@@ -110 +110 @@
                 $this->datahash = md5(serialize($this->data));
 
+
                 // are we actually logged in, fill in more
                 if ($detail['username']) {
+                        // Are we using HTTPS?
+                        if (!isset($_SERVER['HTTPS'])) {
+                                $this->errormsg = "Not using HTTPS";
+                                $this->loggedin = FALSE;
+                                return;
+                        }
+                        // User is valid but they're coming from the wrong IP
+                        if ($detail['ip'] != $_SERVER['REMOTE_ADDR']) {
+                                $this->errormsg = "Invalid IP";
+                                $this->loggedin = FALSE;
+                                return;
+                        }
                         $this->username=$detail['username'];
                         $this->fetch_detail($detail['username']);
@@ -119 +132 @@
                 // update time stamp
                 $DB->Execute( "update {$this->table} set time=NOW() where hash=?", array($this->token));
-
-                // User is valid but something is fishy
-                if ($detail['ip'] != $_SERVER['REMOTE_ADDR']) {
-                        $this->errormsg = "Invalid IP";
-                        $this->loggedin = FALSE;
-                        return;
-                }
         }
 

static/Community.txt

@@ -1 @@
-<p>What are we going to put on this page then?</p><p>I don&#39;t know, but this paragraph was added using the editor :-)&nbsp;</p>
+<p>What are we going to put on this page then?</p><p>I don&#39;t know, but this paragraph was added using the editor :-)&nbsp;</p><p>And this one was added without logging in! Egads, it's a wiki!</p>