Ticket #14 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Formatting and storage of tags in entries needs thinking about

Reported by: welshbyte Assigned to: dez
Priority: normal Milestone: Basic Completeness
Component: blog-admin Version:
Severity: normal Keywords:
Cc:

Description

Currently we are just using nl2br to format entries. I'm not sure when it happened but adding <p> and </p> to messages went missing and now new entries are in divs but not split into paragraphs and look silly (see the last two entries in my blog). A better proposal would be to use htmlentities or htmlspecialchars to stop users from putting html in their entries, replacing multiple newlines with </p><p>, remaining single newlines with <br /> and then we could implement some kind of wiki style markup to add more formatting and links, pictures etc to blogs later.

Change History

01/06/05 23:01:45 changed by dez

Or what about using HTMLarea?

02/06/05 21:47:54 changed by welshbyte

HTMLarea is one possible solution. But I'm concerned about keeping control over what kind of HTML actually goes into the blog entries. I thought disallowing HTML altogether would be the best way to go around this. Also, a wiki/bbcode kind of markup can be easier to tweak manually than HTML and we can extend it to further handiness e.g. [bloglink]welshbyte/bloglink could link straight to another person's blog.

01/07/05 14:55:03 changed by dez

  • owner changed from rollercow to dez.
  • status changed from new to assigned.

Following discussion with rollercow, I have added TinyMCE in [126]. TinyMCE allows you to control the HTML tags allowed, so that issue is addressed.

03/07/05 20:37:17 changed by dez

We now need to implement #18 and only use nl2br if the box is not ticked.

04/07/05 01:46:35 changed by dez

  • status changed from assigned to closed.
  • resolution set to fixed.